Open
Conversation
Richardhongyu
left a comment
Richardhongyu
left a comment
There was a problem hiding this comment.
Great work! You can add more details about how to evaluate this driver and what you can do with this. Besides, you can add some links of the prior mails when we had touch out with the community.
Comment on lines
+17
to
+39
| macro_rules! FSEL_REG { | ||
| ($p:expr) => { | ||
| GPFSEL0 + (($p / 10) * 4) | ||
| }; | ||
| } | ||
|
|
||
| macro_rules! FSEL_SHIFT { | ||
| ($p:expr) => { | ||
| (($p % 10) * 3) | ||
| }; | ||
| } | ||
|
|
||
| macro_rules! GPIO_REG_OFFSET { | ||
| ($p:expr) => { | ||
| $p / 32 | ||
| }; | ||
| } | ||
|
|
||
| macro_rules! GPIO_REG_SHIFT { | ||
| ($p:expr) => { | ||
| $p % 32 | ||
| }; | ||
| } |
There was a problem hiding this comment.
Why not move these to macro.rs of RFL of gpio related files?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite GPIO registration part in
pinctrl-bcm2835.cusing Rust.pinctrl_bcm2835_rust.rshas been tested on thevirtmachine in QEMU, andlibgpiodcan successfully call the GPIO controller through the `pinctrl_bcm2835_rust'.Issue:
bcm2835_rustfails to register on Raspberry Pi 4B, and the error displayed in syslog is:pinctrl_bcm2835_rust: probe of fe200000.gpio failed with error -22
And KGDB and jlink cannot be used to debug this driver since both kgdb and jlink are based on the gpio driver on the board.
Changes needed:
bcm2835_ruston Raspberry Pi 4B.